Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: #261 - error response body needs to be rehydrated #263

Merged
merged 1 commit into from
Jun 3, 2016
Merged

Fixed: #261 - error response body needs to be rehydrated #263

merged 1 commit into from
Jun 3, 2016

Conversation

roblg
Copy link
Member

@roblg roblg commented Jun 3, 2016

Forgot to do this way back in the day, and somebody finally noticed. :)

@gigabo gigabo added the bug An issue with the system label Jun 3, 2016
gigabo
gigabo reviewed Jun 3, 2016
View reviewed changes
packages/react-server/core/ReactServerAgent/__tests__/ReactServerAgentSpec.js

// this will only be defined if rehydrate is working
// properly
expect(entry.err.response.body).toBeDefined();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@gigabo
Copy link
Contributor

gigabo commented Jun 3, 2016

Thanks @roblg. Good fix.

@gigabo gigabo merged commit ee23e0e into redfin:master Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug An issue with the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roblg @gigabo